Mark ComputedStyle of DateTimeEditElement as font-metric-dependent #27766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 24, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2718492
branch
from
e83d452
to
c40e082
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2718492
branch
2 times, most recently
from
95e1c3e
to
9bb390e
Compare
DateTimeEditElement::CustomStyleForLayoutObject() measures text width with the current font, and then uses the result to set the computed value of 'width'. Therefore, this patch marks this ComputedStyle as font-metric-dependent, so that we can properly invalidate it when font changes. Bug: 1167555 Change-Id: I50cf068062bf36223de2949cea83c75a834f59d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718492 Reviewed-by: Fredrik Söderquist <fs@opera.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#859046}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2718492
branch
from
9bb390e
to
3119539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimeEditElement::CustomStyleForLayoutObject() measures text width
with the current font, and then uses the result to set the computed
value of 'width'. Therefore, this patch marks this ComputedStyle as
font-metric-dependent, so that we can properly invalidate it when font
changes.
Bug: 1167555
Change-Id: I50cf068062bf36223de2949cea83c75a834f59d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718492
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859046}