[css-flex] Delete broken redundant flex tests #27768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 24, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2718890
branch
from
4df25e9
to
d2626bf
Compare
These tests rely on a CJK font such that they pass locally and pass in chromium's waterfall, but fail on wpt.fyi. The tests rely on the ordering of glyphs as a pass/fail condition, so using Ahem would make the tests useless. But we can just delete these tests because this functionality is tested by flexbox-writing-mode-0*.html, which we recently imported from mozilla's tree. Change-Id: I810196cce08c05545d60744066154b1999426f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718890 Auto-Submit: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#858084}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2718890
branch
from
d2626bf
to
f80fa58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests rely on a CJK font such that they pass locally and pass in
chromium's waterfall, but fail on wpt.fyi. The tests rely on the
ordering of glyphs as a pass/fail condition, so using Ahem would make
the tests useless.
But we can just delete these tests because this functionality is tested
by flexbox-writing-mode-0*.html, which we recently imported from
mozilla's tree.
Change-Id: I810196cce08c05545d60744066154b1999426f9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718890
Auto-Submit: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858084}