Split VideoFrameInit into VideoFramePlaneInit. Make optional. #27769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 24, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2718896
branch
2 times, most recently
from
43610a5
to
696346e
Compare
We hadn't been using the VideoFrameInit fields properly and it's unclear how a user would know these values ahead of time, so just make the timestamp and duration fields optional while removing all resolution based fields. R=chcunningham, sandersd Bug: 1181894 Test: New tests. Change-Id: I8ea04d2c1b4e5ef7fadb0a0287cd8adad5715862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718896 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#857829}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2718896
branch
from
696346e
to
d5364fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hadn't been using the VideoFrameInit fields properly and it's
unclear how a user would know these values ahead of time, so just
make the timestamp and duration fields optional while removing all
resolution based fields.
R=chcunningham, sandersd
Bug: 1181894
Test: New tests.
Change-Id: I8ea04d2c1b4e5ef7fadb0a0287cd8adad5715862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718896
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857829}