[blink] pass callback function into profiler->StartProfiling #27771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Passing in callback function for profiler->StartProfiling(), which is executed when max samples is reached and samples are being discarded - Server (v8) side CR: https://chromium-review.googlesource.com/c/v8/v8/+/2652206 - Includes web performance tests, verifying delegate function invoked on 101st profiler Change-Id: I7685c95d04fd68ef661011f4b0e7cf079e7dd2b5
wpt-pr-bot
approved these changes
Feb 25, 2021
|
Close this PR because the Chromium CL cannot be found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is executed when max samples is reached and samples are
being discarded
https://chromium-review.googlesource.com/c/v8/v8/+/2652206
invoked on 101st profiler
Change-Id: I7685c95d04fd68ef661011f4b0e7cf079e7dd2b5
Reviewed-on: https://chromium-review.googlesource.com/2649617
WPT-Export-Revision: f3417218cc38a8f03f04fd07ba5d097e91893c8d