Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_script to build options #598

Closed
wants to merge 1 commit into from
Closed

Conversation

slan
Copy link

@slan slan commented Feb 24, 2021

When iterating it's convenient to have the project files updated without running the full synth/impl loop. This PR propagates the top-level run_script argument to the execution phase.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #598 (3db36a6) into master (f7c2b94) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #598   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files          49       49           
  Lines        6461     6461           
  Branches     1287     1287           
=======================================
  Hits         5266     5266           
  Misses       1007     1007           
  Partials      188      188           
Impacted Files Coverage Δ
nmigen/build/plat.py 27.51% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c2b94...3db36a6. Read the comment docs.

@whitequark
Copy link
Member

If you want to customize the build process in this way I suggest passing do_build=False and then using the build plan yourself.

@whitequark whitequark closed this Feb 24, 2021
@slan
Copy link
Author

slan commented Feb 24, 2021

Makes a lot more sense indeed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants