Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrow-cpp: 2.0.0 -> 3.0.0 #110895

Merged
merged 1 commit into from Jan 30, 2021
Merged

arrow-cpp: 2.0.0 -> 3.0.0 #110895

merged 1 commit into from Jan 30, 2021

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Jan 26, 2021

Motivation for this change

https://arrow.apache.org/release/3.0.0.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tobim
Copy link
Contributor Author

tobim commented Jan 26, 2021

Output of nixpkgs-review:

2 packages failed to build:
python37Packages.intake python38Packages.intake

12 packages built:
arrow-cpp python37Packages.datasets python37Packages.google-cloud-bigquery \
python37Packages.ibis-framework python37Packages.pyarrow python37Packages.tokenizers \
python37Packages.transformers python38Packages.datasets python38Packages.google-cloud-bigquery \
python38Packages.pyarrow python38Packages.tokenizers python38Packages.transformers

@tobim
Copy link
Contributor Author

tobim commented Jan 26, 2021

python3Packages.intake fails to build on the parent commit as well.

@ofborg ofborg bot requested a review from veprbl January 26, 2021 21:53
jonringer
jonringer approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/110895

2 packages failed to build:
python37Packages.intake python38Packages.intake

12 packages built:
arrow-cpp python37Packages.datasets python37Packages.google-cloud-bigquery python37Packages.ibis-framework python37Packages.pyarrow python37Packages.tokenizers python37Packages.transformers python38Packages.datasets python38Packages.google-cloud-bigquery python38Packages.pyarrow python38Packages.tokenizers python38Packages.transformers

@jonringer
Copy link
Contributor

checking on aarch64 error though

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110895 run on x86_64-darwin 1

4 packages failed to build and are new build failures:
10 packages built:
  • arrow-cpp
  • python37Packages.datasets
  • python37Packages.google-cloud-bigquery
  • python37Packages.ibis-framework
  • python37Packages.pyarrow
  • python37Packages.tokenizers
  • python37Packages.transformers
  • python38Packages.datasets
  • python38Packages.google-cloud-bigquery
  • python38Packages.pyarrow

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110895 run on x86_64-linux 1

2 packages failed to build and are new build failures:
12 packages built:
  • arrow-cpp
  • python37Packages.datasets
  • python37Packages.google-cloud-bigquery
  • python37Packages.ibis-framework
  • python37Packages.pyarrow
  • python37Packages.tokenizers
  • python37Packages.transformers
  • python38Packages.datasets
  • python38Packages.google-cloud-bigquery
  • python38Packages.pyarrow
  • python38Packages.tokenizers
  • python38Packages.transformers

@jonringer
Copy link
Contributor

it does seem to be a regression on aarch64

@veprbl
Copy link
Member

veprbl commented Jan 27, 2021

@GrahamcOfBorg build pkgsi686Linux.arrow-cpp

@tobim
Copy link
Contributor Author

tobim commented Jan 27, 2021

Disabled the specific tests for now.

Reported the aarch64 test failures upstream: https://issues.apache.org/jira/browse/ARROW-11398

@ofborg ofborg bot requested a review from veprbl January 27, 2021 10:33
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110895 run on x86_64-darwin 1

4 packages failed to build and are new build failures:
10 packages built:
  • arrow-cpp (parquet-cpp)
  • python37Packages.datasets
  • python37Packages.google-cloud-bigquery
  • python37Packages.ibis-framework
  • python37Packages.pyarrow
  • python37Packages.tokenizers
  • python37Packages.transformers
  • python38Packages.datasets
  • python38Packages.google-cloud-bigquery
  • python38Packages.pyarrow

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110895 run on x86_64-linux 1

2 packages failed to build and are new build failures:
12 packages built:
  • arrow-cpp (parquet-cpp)
  • python37Packages.datasets
  • python37Packages.google-cloud-bigquery
  • python37Packages.ibis-framework
  • python37Packages.pyarrow
  • python37Packages.tokenizers
  • python37Packages.transformers
  • python38Packages.datasets
  • python38Packages.google-cloud-bigquery
  • python38Packages.pyarrow
  • python38Packages.tokenizers
  • python38Packages.transformers

@ofborg ofborg bot requested a review from veprbl January 27, 2021 16:05
@veprbl veprbl merged commit 2a07b6e into NixOS:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@veprbl veprbl Awaiting requested review from veprbl

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tobim @jonringer @SuperSandro2000 @veprbl