Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: 0.35.1 -> 0.36.0 #110896

Merged
merged 1 commit into from Jan 31, 2021
Merged

crystal: 0.35.1 -> 0.36.0 #110896

merged 1 commit into from Jan 31, 2021

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Jan 26, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

Cc @NixOS/crystal-lang

david50407
david50407 approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@david50407 david50407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110896 run on x86_64-darwin 1

5 packages failed to build and already failed to build on hydra master:
  • ameba: log was empty
  • crystal: log was empty
  • crystal2nix: log was empty
  • icr: log was empty
  • oq: log was empty
2 packages failed to build and are new build failures:
  • (crystal_0_36): log was empty
  • lucky-cli: log was empty
Semantic: instance var doesn't infer type to be nilable if using self.class in call in assign
Semantic: pointer allows using pointer with subclass
Semantic: primitives types pointer of int
Failures:
1) Crystal::Command::FormatCommand formats stdin (bug + show-backtrace)
Error running at_exit handler: Nil assertion failed
make: *** [Makefile:104: compiler_spec] Error 1

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110896 run on x86_64-linux 1

1 package failed to build and already failed to build on hydra master:
1 package failed to build and are new build failure:
4 packages built:
  • crystal (crystal_0_36)
  • crystal2nix
  • icr
  • lucky-cli

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

crystal:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '{% if flag?(:gnu) %}"listen: "{% else %}"bind: "{% end %}' doesn't match anything in file 'spec/std/socket/tcp_server_spec.cr'
substituteStream(): WARNING: pattern '01 Jan 2020' doesn't match anything in file 'spec/std/http/cookie_spec.cr'

Please check the offending substituteInPlace for typos or changes in source.

Br1ght0ne
Br1ght0ne approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianhjr
Copy link
Member Author

Hi, this is a ping/bump to merge.

@danieldk danieldk merged commit ef84ed9 into NixOS:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david50407 david50407 david50407 approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fabianhjr @peterhoeg @SuperSandro2000 @david50407 @Br1ght0ne @danieldk