Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hg-git: 0.8.12 -> 0.9.0 #110832

Closed
wants to merge 2 commits into from
Closed

hg-git: 0.8.12 -> 0.9.0 #110832

wants to merge 2 commits into from

Conversation

HolgerPeters
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@HolgerPeters HolgerPeters marked this pull request as draft January 26, 2021 06:53
SuperSandro2000
SuperSandro2000 reviewed Jan 26, 2021
View reviewed changes
pkgs/development/python-modules/hg-git/0.8.12.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/hg-git/0.8.12.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/hg-git/0.8.12.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/hg-git/0.8.12.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/mercurial/4.9.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Please squash the review commits together and do not use fixup! because GitHub does not correctly merge them all the time.

@HolgerPeters
Copy link
Contributor Author

So, after having a repo that allowed me to build packages, I have realized two things

  1. it seems that on python 2(mercurial 4) brotli is needed as a dependency https://foss.heptapod.net/mercurial/hg-git/-/issues/326 and I guess it makes sense to have that for both hg 4 and 5.
  2. mercurial 4 works with the updated hg-git so there is no need to maintain the old hg-git version in parallel and I removed that part from the PR.

I was able to build mercurial 4 and mercurial 5 this way and could clone git repositories using hg clone .... once I enabled hggit in the mercurial configuration.

@ofborg ofborg bot requested a review from edolstra January 28, 2021 20:48
@HolgerPeters HolgerPeters force-pushed the hg-git-update branch 2 times, most recently from 85c2ee9 to 5a05d6a Compare January 30, 2021 11:22
@Mic92 Mic92 changed the title Hg git update [WIP] hg-git: update [WIP] Jan 30, 2021
@HolgerPeters HolgerPeters changed the title hg-git: update [WIP] hg-git: update Feb 1, 2021
@HolgerPeters HolgerPeters marked this pull request as ready for review February 6, 2021 18:04
@HolgerPeters
Copy link
Contributor Author

I am not quite sure what change is still missing, Github shows me 1 change request would still be open but I cannot find which one that is.

@SuperSandro2000
Copy link
Member

I am not quite sure what change is still missing, Github shows me 1 change request would still be open but I cannot find which one that is.

That feature is buggy but I think after the change I noted above it is ready to go.

@lukegb lukegb changed the title hg-git: update hg-git: 0.8.12 -> 0.9.0 Sep 5, 2021
@SuperSandro2000
Copy link
Member

newer version already on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HolgerPeters @SuperSandro2000 @lukegb