Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: 0.4.4 -> 0.5.0 #110837

Merged
merged 2 commits into from Jul 2, 2021
Merged

neovim: 0.4.4 -> 0.5.0 #110837

merged 2 commits into from Jul 2, 2021

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Jan 26, 2021 •
edited

Motivation for this change

Upstream update.
0.5.0 is not released yet - this branch tracks latest nightly until then.
I will be doing my best to keep this up-to-date with latest nightly.
While we're waiting for 0.5.0 to be released, we can already prepare for it in this PR.
Added a new neovim-nightly package, which tracks nightly https://github.com/neovim/neovim/releases/tag/nightly

It's finally here! 🎉
Closes #128959

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build neovim

@ofborg ofborg bot requested review from Ma27 and manveru January 26, 2021 10:32
@rvolosatovs
Copy link
Member Author

Updated PR with this approach #110837 (comment)

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build neovim-nightly

@rvolosatovs rvolosatovs marked this pull request as ready for review January 26, 2021 13:51
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110837 run on x86_64-darwin 1

1 package failed to build and are new build failure:

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110837 run on x86_64-linux 1

1 package built:
  • neovim-nightly-unwrapped

@rvolosatovs rvolosatovs changed the title neovim: 0.4.4 -> 0.5.0 neovim: init nightly at unstable-0.5.0 Jan 26, 2021
@teto
Copy link
Member

teto commented Jan 26, 2021

Why duplicate everything instead of an override with just treesitter ?

I am on the fence for this one. I've wanted to provide a neovim nightly in nixpkgs for a long time but was afraid it would be rejected (for valid reasons: if everyone starts packaging a pseudo-nigthly for its software, it can get out of hands). Instead I've added a flake to neovim so that one can install a true nightly via flakes see https://nixos.wiki/wiki/Neovim for doc.

As a datapoint, I hope we can release 0.5 in Ferbuary and no later than March so there is not long to wait.

@rvolosatovs
Copy link
Member Author

rvolosatovs commented Jan 27, 2021 •
edited

Why duplicate everything instead of an override with just treesitter ?

I am on the fence for this one. I've wanted to provide a neovim nightly in nixpkgs for a long time but was afraid it would be rejected (for valid reasons: if everyone starts packaging a pseudo-nigthly for its software, it can get out of hands). Instead I've added a flake to neovim so that one can install a true nightly via flakes see nixos.wiki/wiki/Neovim for doc.

As a datapoint, I hope we can release 0.5 in Ferbuary and no later than March so there is not long to wait.

I agree as well and that is also why I don't want to include a nightly in Nixpkgs.
I will revert the PR to it's original state (draft simply updating the version to 0.5.0)

@rvolosatovs rvolosatovs marked this pull request as draft January 27, 2021 10:42
@rvolosatovs rvolosatovs changed the title neovim: init nightly at unstable-0.5.0 neovim: 0.4.4 -> 0.5.0 Jan 27, 2021
@carlocab carlocab mentioned this pull request Jun 29, 2021
Closed
@carlocab
Copy link

I opened tree-sitter/tree-sitter#1216 to see if they might cut a new release tag.

@carlocab carlocab mentioned this pull request Jun 29, 2021
Merged
@tomcur
Copy link
Contributor

tomcur commented Jun 29, 2021

Upstream has an open PR to put the function call behind a feature guard (neovim/neovim#14930). It builds successfully:

$ nix build 'github:neovim/neovim/7e8a8482e8e474b9ec45c1bd147dd0b0f4ff03af?dir=contrib'
$ ./result/bin/nvim --version
NVIM v0.5.0-dev
...

@rvolosatovs
Copy link
Member Author

Upstream has an open PR to put the function call behind a feature guard (neovim/neovim#14930). It builds successfully:

$ nix build 'github:neovim/neovim/7e8a8482e8e474b9ec45c1bd147dd0b0f4ff03af?dir=contrib'
$ ./result/bin/nvim --version
NVIM v0.5.0-dev
...

Added it in 4069de5

@rvolosatovs rvolosatovs mentioned this pull request Jul 1, 2021
Merged
11 tasks
@rvolosatovs
Copy link
Member Author

FYI, latest nightly with tree-sitter 0.20.0 available in my nixos-unstable branch https://github.com/rvolosatovs/nixpkgs/tree/nixos-unstable
In particular, this commit rvolosatovs@c17c3eb if you want to check it out

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build neovim

@rvolosatovs rvolosatovs mentioned this pull request Jul 2, 2021
Closed
@rvolosatovs rvolosatovs marked this pull request as ready for review July 2, 2021 16:10
@lovesegfault
Copy link
Member

Testing this

@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 110837 run on x86_64-linux 1

7 packages built:
  • gnvim
  • neovim
  • neovim-qt
  • neovim-qt-unwrapped
  • neovim-remote
  • neovim-unwrapped
  • nvimpager

@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 110837 run on aarch64-linux 1

7 packages built:
  • gnvim
  • neovim
  • neovim-qt
  • neovim-qt-unwrapped
  • neovim-remote
  • neovim-unwrapped
  • nvimpager

@lovesegfault lovesegfault merged commit a143a6d into NixOS:master Jul 2, 2021
@rvolosatovs rvolosatovs deleted the update/neovim branch July 2, 2021 18:56
@dbarrosop dbarrosop mentioned this pull request Jul 3, 2021
Closed
@rvolosatovs rvolosatovs mentioned this pull request Jul 7, 2021
Merged
11 tasks
lucasew added a commit to lucasew/nixcfg that referenced this pull request Sep 26, 2021
@lucasew
moved neovim module to packages and overrided it to 0.5.0 based on Ni…
ddd70a5 
…xOS/nixpkgs#110837

Signed-off-by: lucasew <lucas59356@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner gebner left review comments

@thiagokokada thiagokokada thiagokokada left review comments

@moni-dz moni-dz moni-dz approved these changes

@Kranzes Kranzes Kranzes approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

@manveru manveru Awaiting requested review from manveru

@teto teto Awaiting requested review from teto teto is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

neovim compiles against Lua 5.1 instead of luajit on aarch64-darwin
10 participants
@rvolosatovs @SuperSandro2000 @teto @carlocab @tomcur @lovesegfault @gebner @thiagokokada @moni-dz @Kranzes