Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: add services.rsyncd.socketActivated option #110841

Merged
merged 1 commit into from Jan 28, 2021
Merged

nixos: add services.rsyncd.socketActivated option #110841

merged 1 commit into from Jan 28, 2021

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Jan 26, 2021

Motivation for this change

Define systemd-socket activation using the upstream configuration files as a reference.

Can be tested on my laptop via yggdrasil rsync://[200:d812:c658:6c76:f46:7131:114c:35f3] :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ehmry
nixos: add services.rsyncd.socketActivated option
58e1051 
Define systemd-socket activation using the upstream configuration
files as a reference. The "rsyncd" systemd unit has been renamed
to "rsync" for consistency with upstream.
@ehmry ehmry requested a review from Nadrieril January 26, 2021 11:15
@Nadrieril
Copy link
Member

Nice, I've wanted this feature before. Not sure why you thought of me as a reviewer, I don't feel competent here sorry >< Not familiar with systemd shenanigans. Looks good as far as I can see though.
You'll have to find someone else to review it, I don't have merge rights. Thanks for taking the time to do this :)

@ehmry ehmry merged commit f32d7e4 into NixOS:master Jan 28, 2021
@ehmry ehmry deleted the rsync branch January 28, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadrieril Nadrieril Awaiting requested review from Nadrieril

Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehmry @Nadrieril