Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-snmp: 5.8 -> 5.9 #110867

Merged
merged 1 commit into from Jan 30, 2021
Merged

net-snmp: 5.8 -> 5.9 #110867

merged 1 commit into from Jan 30, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Fixes CVE-2019-20892.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 110867 run on x86_64-darwin 1

18 packages marked as broken and skipped:
  • fgallery
  • gscan2pdf
  • haskellPackages.bindings-sane
  • ifstat-legacy
  • odpdown
  • perl530Packages.ImageSane
  • perl532Packages.ImageSane
  • prometheus-snmp-exporter
  • python37Packages.paperwork-backend
  • python37Packages.paperwork-shell
  • python37Packages.sane
  • python38Packages.paperwork-backend
  • python38Packages.paperwork-shell
  • python38Packages.sane
  • python39Packages.paperwork-backend
  • python39Packages.paperwork-shell
  • python39Packages.sane
  • quagga

danieldk
danieldk approved these changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 110867 run on x86_64-linux 1
LGTM. nix-review for a subset of packages that depend on net-smnp:

4 packages built:
  • dnsdist
  • hplip
  • quagga
  • rsyslog

@danieldk danieldk merged commit 99726bd into NixOS:master Jan 30, 2021
@danieldk
Copy link
Contributor

@LeSuisse Thanks for the update! Could you backport this change or a fix for the CVE to 20.09?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110867 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • gscan2pdf
  • libsForQt512.discover
  • libsForQt514.discover
3 packages failed to build and are new build failures:
  • libreoffice-fresh: log was empty
  • libreoffice-fresh-unwrapped: log https://termbin.com/flr4
  • libreoffice-qt: log was empty
131 packages built:
  • _389-ds-base
  • adapta-gtk-theme
  • argus
  • check-wmiplus
  • chrome-gnome-shell
  • cinnamon.cinnamon-common
  • cinnamon.cinnamon-control-center
  • cinnamon.cinnamon-gsettings-overrides
  • cinnamon.cinnamon-screensaver
  • cinnamon.cinnamon-session
  • cinnamon.cinnamon-settings-daemon
  • collectd
  • collectd-data
  • colord
  • colord-gtk
  • darktable
  • dnsdist
  • eolie
  • epkowa
  • fbida
  • fgallery
  • fwupd
  • gImageReader
  • geeqie
  • gnome-firmware-updater
  • gnome3.gnome-color-manager
  • gnome3.gnome-control-center (gnome3.gnome_control_center)
  • gnome3.gnome-disk-utility
  • gnome3.gnome-session (gnome3.gnome_session)
  • gnome3.gnome-settings-daemon (gnome3.gnome_settings_daemon)
  • gnome3.gnome-shell (gnome3.gnome_shell)
  • gnome3.gnome-software
  • gnome3.gnome-terminal (gnome3.gnome_terminal)
  • gnome3.gnome-tweaks (gnome3.gnome-tweak-tool)
  • gnome3.gpaste
  • gnome3.mutter
  • pantheon.mutter (gnome3.mutter334)
  • gnome3.pomodoro
  • simple-scan (gnome3.simple-scan)
  • gnomeExtensions.easyScreenCast
  • gnomeExtensions.gsconnect
  • gnomeExtensions.night-theme-switcher
  • gnomeExtensions.system-monitor
  • haskellPackages.bindings-sane
  • hplip
  • hplipWithPlugin
  • hplipWithPlugin_3_16_11
  • hplipWithPlugin_3_18_5
  • hplip_3_16_11
  • hplip_3_18_5
  • ifstat-legacy
  • keepalived
  • libinsane
  • libreoffice-still
  • libreoffice-unwrapped (libreoffice-still-unwrapped)
  • libsForQt5.discover (libsForQt515.discover ,plasma5Packages.discover)
  • libsForQt5.libksane (libsForQt515.libksane ,plasma5Packages.libksane)
  • libsForQt512.libksane
  • libsForQt514.libksane
  • lldpd
  • lutris
  • lutris-free
  • lutris-unwrapped
  • masterpdfeditor
  • masterpdfeditor4
  • monitor
  • monitoring-plugins
  • net-snmp
  • ocrfeeder
  • odpdown
  • pantheon.elementary-dpms-helper
  • pantheon.elementary-greeter
  • pantheon.elementary-gsettings-schemas
  • pantheon.elementary-session-settings
  • pantheon.elementary-settings-daemon
  • pantheon.gala
  • pantheon.switchboard-plug-mouse-touchpad
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-bluetooth
  • pantheon.wingpanel-indicator-datetime
  • pantheon.wingpanel-indicator-keyboard
  • pantheon.wingpanel-indicator-network
  • pantheon.wingpanel-indicator-nightlight
  • pantheon.wingpanel-indicator-notifications
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-indicator-session
  • pantheon.wingpanel-indicator-sound
  • pantheon.wingpanel-with-indicators
  • paperwork
  • perl530Packages.ImageSane
  • perl532Packages.ImageSane
  • php73Extensions.snmp
  • phpExtensions.snmp (php74Extensions.snmp)
  • php80Extensions.snmp
  • pipelight
  • playonlinux
  • prometheus-snmp-exporter
  • python37Packages.paperwork-backend
  • python37Packages.paperwork-shell
  • python37Packages.sane
  • python38Packages.paperwork-backend
  • python38Packages.paperwork-shell
  • python38Packages.sane
  • python39Packages.paperwork-backend
  • python39Packages.paperwork-shell
  • python39Packages.sane
  • quagga
  • rsyslog
  • sane-airscan
  • sane-backends
  • sane-backends-git
  • sane-frontends
  • scanbd
  • skanlite
  • tellico
  • unoconv
  • utsushi
  • weston
  • westonLite
  • xdg-desktop-portal-gtk
  • xiccd
  • xsane
  • zabbix.proxy-mysql (zabbix50.proxy-mysql)
  • zabbix.proxy-pgsql (zabbix50.proxy-pgsql)
  • zabbix.proxy-sqlite (zabbix50.proxy-sqlite)
  • zabbix.server (zabbix.server-pgsql ,zabbix50.server ,zabbix50.server-pgsql)
  • zabbix.server-mysql (zabbix50.server-mysql)

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

check-wmiplus:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/usr/bin/perl' doesn't match anything in file 'check_wmi_plus_help.pl'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/servers/monitoring/plugins/wmiplus/default.nix:74:5:

   |
74 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

odpdown:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
paperwork:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python37Packages.sane:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python38Packages.sane:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python39Packages.sane:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
sane-backends-git:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '-ljpeg' doesn't match anything in file '/nix/store/w5k5i4r0f7s71pzd4szwm6a87r38zazg-sane-backends-2017-12-01/lib/libsane.la'

Please check the offending substituteInPlace for typos or changes in source.

sane-backends:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '-ljpeg' doesn't match anything in file '/nix/store/dswbl77p8bcgfgsk66j8acsb1888rpw5-sane-backends-1.0.30/lib/libsane.la'

Please check the offending substituteInPlace for typos or changes in source.

zabbix.server:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libopenssl.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/pthread.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libunixodbc.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libcurl.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/ax_lib_mysql.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/ldap.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libevent.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/iconv.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/netsnmp.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/ax_lib_sqlite3.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libssh.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libssh2.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libgnutls.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/openipmi.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/pcre.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/zlib.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/ax_lib_postgresql.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/ax_lib_oracle_oci.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/resolv.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './aclocal.m4'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/servers/monitoring/zabbix/server.nix:89:9:

   |
89 |         license = licenses.gpl2;
   |         ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

zabbix.server-mysql:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libopenssl.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/pthread.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libunixodbc.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libcurl.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/ax_lib_mysql.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/ldap.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libevent.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/iconv.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/netsnmp.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/ax_lib_sqlite3.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libssh.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libssh2.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/libgnutls.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/openipmi.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/pcre.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/zlib.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/ax_lib_postgresql.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/ax_lib_oracle_oci.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './m4/resolv.m4'
substituteStream(): WARNING: pattern 'test -x "$PKG_CONFIG"' doesn't match anything in file './aclocal.m4'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/servers/monitoring/zabbix/server.nix:89:9:

   |
89 |         license = licenses.gpl2;
   |         ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@LeSuisse LeSuisse deleted the net-snmp-5.9 branch February 1, 2021 07:49
@LeSuisse LeSuisse added the 8.has: port to stable A PR already has a backport to the stable release. label Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@TredwellGit TredwellGit TredwellGit approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LeSuisse @SuperSandro2000 @danieldk @TredwellGit