Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elmPackages: Updates Elm node packages to latest versions. #110845

Closed
wants to merge 1 commit into from
Closed

elmPackages: Updates Elm node packages to latest versions. #110845

wants to merge 1 commit into from

Conversation

akoppela
Copy link

@akoppela akoppela commented Jan 26, 2021 •
edited

Motivation for this change

Updated Elm node packages to the latest versions. This operation is automatic and done with existing script. No manual changes were done.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from turboMaCk January 26, 2021 12:00
@turboMaCk
Copy link
Member

@GrahamcOfBorg build elmPackages

@turboMaCk
Copy link
Member

It seems will require some manual work:

error: build of '/nix/store/xgs51zcl385jpgl0gjax43kmapcpxvdl-node_elm-review-2.4.0.drv' failed

There is also this PR in progress #110813 (review) which will allow us to reuse node-env.nix. I don't think this upgrade is necessarily blocked by that.

a. You can fix the build of elm-review
b. If you don't want to spend time on this you can close the PR and I'll open new one myself once #110813 is in

@turboMaCk
Copy link
Member

I had a brief looks and to me it seems

  1. elm-review removed npm dependecy on binwrap.
  2. elm-json is still a dependecy but it's not downloaded on installation but rather when elm-review starts.

The simplest way to solve this is to remove patchBinwrap call for elm review. The downside is that that way we would let elm-review to fetch it's own elm-json binary and not the one we build as a part of package set.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110845 run on x86_64-linux 1

1 package failed to build and are new build failure:
10 packages built:
  • elmPackages.create-elm-app
  • elmPackages.elm-analyse
  • elmPackages.elm-coverage
  • elmPackages.elm-doc-preview
  • elmPackages.elm-language-server
  • elmPackages.elm-live
  • elmPackages.elm-optimize-level-2
  • elmPackages.elm-test
  • elmPackages.elm-upgrade
  • elmPackages.elm-verify-examples

This was referenced Feb 2, 2021
Merged
Merged
@akoppela akoppela deleted the update-elm-node-packages branch February 11, 2021 12:34
@akoppela
Copy link
Author

Thank you sirs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turboMaCk turboMaCk Awaiting requested review from turboMaCk

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akoppela @turboMaCk @SuperSandro2000