Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mediathekview: 13.5.1 -> 13.7.0 #110833

Merged
merged 2 commits into from Jan 26, 2021
Merged

mediathekview: 13.5.1 -> 13.7.0 #110833

merged 2 commits into from Jan 26, 2021

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Jan 26, 2021 •
edited

Motivation for this change

Version bump. When testing please make a backup of yout configuration as citing from the release page:

Erstellt vor dem Update zwingend ein Backup eurer Konfiguration! Ein Mischbetrieb von 13.7 und älteren Versionen ist ohne Verlust von Downloadhistorie und anderen Parametern NICHT möglich!!!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread Moredread mentioned this pull request Jan 26, 2021
Closed
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110833 run on x86_64-darwin 1

1 package built:
  • mediathekview

@SuperSandro2000
Copy link
Member

Version bump. When testing please make a backup of yout configuration as citing from the release page:

Does this require a changelog entry?

@dotlambda
Copy link
Member

Version bump. When testing please make a backup of yout configuration as citing from the release page:

Does this require a changelog entry?

No, why would people ever downgrade their version?

@Moredread
Copy link
Contributor Author

Version bump. When testing please make a backup of yout configuration as citing from the release page:

Does this require a changelog entry?

I guess in principal it would be nice to document that, but other packages like afaik syncthing and joplin had non-backwards compatible updates without changelog entries.

@SuperSandro2000 SuperSandro2000 merged commit 4140459 into NixOS:master Jan 26, 2021
@Moredread Moredread deleted the mediathekview branch January 26, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Moredread @SuperSandro2000 @dotlambda @r-ryantm