Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvirt: 6.8.0 -> 7.0.0 #110874

Merged
merged 4 commits into from Jan 27, 2021
Merged

libvirt: 6.8.0 -> 7.0.0 #110874

merged 4 commits into from Jan 27, 2021

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jan 26, 2021

Motivation for this change

Update libvirt to version 7.0.0. Removed unknow mesonFlags.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110874 run on x86_64-darwin 1

7 packages marked as broken and skipped:
  • collectd
  • collectd-data
  • python37Packages.guestfs
  • python38Packages.guestfs
  • python39Packages.guestfs
  • terraform-full
  • virt-manager-qt
2 packages failed to build and are new build failures:
6 packages built:
  • docker-machine-kvm
  • haskellPackages.libvirt-hs
  • libvirt
  • python37Packages.libvirt
  • python38Packages.libvirt
  • python39Packages.libvirt

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110874 run on x86_64-linux 1

1 package failed to build and already failed to build on hydra master:
  • libvmi: log was empty
30 packages built:
  • collectd
  • collectd-data
  • docker-machine-kvm
  • docker-machine-kvm2
  • gnome3.gnome-boxes
  • haskellPackages.libvirt-hs
  • libguestfs
  • libvirt
  • libvirt-glib
  • minikube
  • minishift
  • perl530Packages.SysVirt
  • perl532Packages.SysVirt
  • python37Packages.guestfs
  • python37Packages.libvirt
  • python38Packages.guestfs
  • python38Packages.libvirt
  • python39Packages.guestfs
  • python39Packages.libvirt
  • rubyPackages.ruby-libvirt (rubyPackages_2_6.ruby-libvirt)
  • rubyPackages_2_5.ruby-libvirt
  • rubyPackages_2_7.ruby-libvirt
  • terraform-full
  • terraform-providers.libvirt
  • vagrant
  • virt-manager
  • virt-manager-qt
  • virt-top
  • virt-viewer
  • virtlyst

@teto
Copy link
Member

teto commented Jan 27, 2021

happy to see nixpkgs' libvirt catcing up after remaining stalled for so long

Nixpkgs-review

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/110874

1 package failed to build:
libvmi

30 packages built:
collectd collectd-data docker-machine-kvm docker-machine-kvm2 gnome3.gnome-boxes haskellPackages.libvirt-hs libguestfs libvirt libvirt-glib minikube minishift perl530Packages.SysVirt perl532Packages.SysVirt python37Packages.guestfs python37Packages.libvirt python38Packages.guestfs python38Packages.libvirt python39Packages.guestfs python39Packages.libvirt rubyPackages.ruby-libvirt rubyPackages_2_5.ruby-libvirt rubyPackages_2_7.ruby-libvirt terraform-full terraform-providers.libvirt vagrant virt-manager virt-manager-qt virt-top virt-viewer virtlyst

but libvmi already fails on nixos-unstable (due to xen failing ?). I haven't tried to start the service but it looks ok

@jonringer
Copy link
Contributor

@GrahamcOfBorg test docker

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/110874

1 package failed to build:
libvmi

30 packages built:
collectd collectd-data docker-machine-kvm docker-machine-kvm2 gnome3.gnome-boxes haskellPackages.libvirt-hs libguestfs libvirt libvirt-glib minikube minishift perl530Packages.SysVirt perl532Packages.SysVirt python37Packages.guestfs python37Packages.libvirt python38Packages.guestfs python38Packages.libvirt python39Packages.guestfs python39Packages.libvirt rubyPackages.ruby-libvirt rubyPackages_2_5.ruby-libvirt rubyPackages_2_7.ruby-libvirt terraform-full terraform-providers.libvirt vagrant virt-manager virt-manager-qt virt-top virt-viewer virtlyst

@jonringer jonringer merged commit c699a6a into NixOS:master Jan 27, 2021
@Izorkin Izorkin deleted the update-libvirt branch January 28, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants