Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/cntlm: add types #110875

Merged
merged 1 commit into from Jan 26, 2021
Merged

nixos/cntlm: add types #110875

merged 1 commit into from Jan 26, 2021

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

#76184

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 previously requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title to nixos/cntlm: add types

cole-h
cole-h requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename your commit message to follow the format mentioned in our CONTRIBUTING document -- specifically, replace the backslash with a forward slash: nixos/cntlm.

Amongst other things, this makes it easier to grep the git log.

bbjubjub2494
bbjubjub2494 suggested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@bbjubjub2494 bbjubjub2494 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use a forward slash, not a backslash in the commit message. Sorry I'm late on that.

Looks good otherwise.

nixos/modules/services/networking/cntlm.nix Outdated Show resolved Hide resolved
@Scriptkiddi
Copy link
Contributor Author

done

@Scriptkiddi Scriptkiddi changed the title nixos\cntlm: add types nixos/cntlm: add types Jan 26, 2021
cole-h
cole-h approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, thanks.

@cole-h cole-h merged commit 5f47218 into NixOS:master Jan 26, 2021
@Scriptkiddi Scriptkiddi deleted the cntlm branch January 27, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbjubjub2494 bbjubjub2494 bbjubjub2494 requested changes

@cole-h cole-h cole-h approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Scriptkiddi @SuperSandro2000 @bbjubjub2494 @cole-h