Just tow remarks:

• cJSON is a new requirement -> cjson: init at 1.7.14 #107169
• 2.0.6 was released

I don't really think we need to keep both v1 and v2. The changes are relatively minor and therefore quite easy to work around in the nixos module.

I don't really think we need to keep both v1 and v2. The changes are relatively minor and therefore quite easy to work around in the nixos module.

Reworked the PR as a simple version update. Added cJSON to buildInputs.

@peterhoeg I haven't touched the nixos module, will you update nixos/modules/services/networking/mosquitto.nix?

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110863 run on x86_64-darwin 1

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110863 run on x86_64-linux 1

Authentication with Mosquitto broke (Connection refused: not authorized) in the nixosTests.home-assistant due to this upgrade. This is our setup:

The credentials are being reused for home-assistant and mosquitto_sub:

Looking for advice.

I wanted to, but didn't have a chance to work through the module, so I suggest we do this.

1. revert this
2. introduce a new mosquitto2 with this version
3. introduce mosquitto1 with the latest 1.6.x
4. make mosquitto an alias for mosquitto1

1.6 is still maintained (and there are some security fixes we need) so we can then always add proper support in the nixos module.

hass # [    4.109957] mosquitto[761]: 1617846007: The 'bind_address' option is now deprecated and will be removed in a future version. The behaviour will default to true.
hass # [    4.110884] mosquitto[761]: 1617846007: The 'port' option is now deprecated and will be removed in a future version. Please use 'listener' instead.
hass # [    4.112071] mosquitto[761]: 1617846007: mosquitto version 2.0.10 starting
hass # [    4.112542] mosquitto[761]: 1617846007: Config loaded from /nix/store/mkrjj35ij3hld114h3gz4x2cmkiyxj2d-mosquitto.conf.
hass # [    4.114645] mosquitto[761]: 1617846007: Warning: ACL pattern '#' does not contain '%c' or '%u'.
hass # [    4.117063] mosquitto[761]: 1617846007: Opening ipv4 listen socket on port 1883.
hass # [    4.117545] mosquitto[761]: 1617846007: mosquitto version 2.0.10 running

Two deprecation warnings, which should probably have been addressed in this pull request. @prusnak @SuperSandro2000

And probably my issue: A warning for the ACL pattern topic readwrite #. Great.

eclipse/mosquitto@39170d1

So one problem was that checkPasswords was not set, so the password file was not included.

Second issue is, that the following command exits with 1 ("Timed out") since 2.0.

"mosquitto_sub -V mqttv311 -t home-assistant/test -u ${mqttUsername} -P '${mqttPassword}' -W 1 -t '*'"

Also not sure why -t was given twice, makes no sense to me.