Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terragrunt: 0.27.1 -> 0.27.3 #110864

Merged
merged 2 commits into from Jan 26, 2021
Merged

terragrunt: 0.27.1 -> 0.27.3 #110864

merged 2 commits into from Jan 26, 2021

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Jan 26, 2021 •
edited

Motivation for this change

Removed makeWrapper as it's been unused since we stopped wrapping up TF
Added -s and -w ldflags to minify terragrunt

Before:
28 MB  terragrunt
After:
25 MB  terragrunt

Bumped to 0.27.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
terragrunt: remove unused dependency and compile smaller
ca1bc75 
Removed makeWrapper as it's been unused since we stopped wrapping up TF
Added -s and -w ldflags to minify terragrunt
@06kellyjac
terragrunt: 0.27.1 -> 0.27.3
1358076
@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 110864 run on x86_64-linux 1

1 package built:
  • terragrunt

@ofborg ofborg bot requested review from peterhoeg and kalbasit January 26, 2021 17:13
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110864 run on x86_64-darwin 1

1 package built:
  • terragrunt

@SuperSandro2000 SuperSandro2000 merged commit f6f2333 into NixOS:master Jan 26, 2021
@06kellyjac 06kellyjac deleted the terragrunt branch January 26, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@06kellyjac @SuperSandro2000