Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nicotine-plus: 1.4.1 -> 3.0.6 #110888

Merged
merged 1 commit into from May 10, 2021
Merged

nicotine-plus: 1.4.1 -> 3.0.6 #110888

merged 1 commit into from May 10, 2021

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Jan 26, 2021

Motivation for this change

Our Nicotine+ is quite old.

https://nicotine-plus.github.io/nicotine-plus/NEWS.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ehmry ehmry requested a review from klntsky January 26, 2021 20:35
@ehmry ehmry marked this pull request as draft January 26, 2021 20:47
@ehmry
Copy link
Contributor Author

ehmry commented Jan 26, 2021 

(nicotine-plus:12677): GLib-GIO-ERROR **: 21:42:56.631: No GSettings schemas are installed on the system
fish: “nix run .#nicotine-plus” terminated by signal SIGTRAP (Trace or breakpoint trap)

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110888 run on x86_64-darwin 1

1 package built:
  • nicotine-plus

@ehmry ehmry marked this pull request as ready for review May 8, 2021 08:08
@ehmry ehmry changed the title nicotine-plus: 1.4.1 -> 2.2.2 nicotine-plus: 1.4.1 -> 3.0.6 May 8, 2021
mathiascode
mathiascode reviewed May 8, 2021
View reviewed changes
Copy link

@mathiascode mathiascode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the Nicotine+ package!

pkgs/applications/networking/soulseek/nicotine-plus/default.nix Outdated Show resolved Hide resolved
@ehmry
Copy link
Contributor Author

ehmry commented May 8, 2021

@mathiascode thanks for the review.

klntsky
klntsky approved these changes May 9, 2021
View reviewed changes
Copy link
Member

@klntsky klntsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehmry ehmry merged commit b593afb into NixOS:master May 10, 2021
@ehmry ehmry deleted the nicotine-plus branch May 10, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiascode mathiascode mathiascode left review comments

@klntsky klntsky klntsky approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ehmry @SuperSandro2000 @mathiascode @klntsky