Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: modules/prometheus: finish exporter setup #110870

Merged
merged 1 commit into from Apr 18, 2022
Merged

docs: modules/prometheus: finish exporter setup #110870

merged 1 commit into from Apr 18, 2022

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jan 26, 2021 •
edited

The last step, in which the exporter is hooked up to the server, was missing.

See https://christine.website/blog/prometheus-grafana-loki-nixos-2020-11-20

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asymmetric
docs: modules/prometheus: finish exporter setup
57e5fe7 
The last step, in which the exporter is hooked up to the server, was missing.
Flakebi
Flakebi approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ajs124 ajs124 merged commit 3fedfb5 into NixOS:master Apr 18, 2022
@asymmetric asymmetric deleted the doc/prom-node-exp branch April 20, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flakebi Flakebi Flakebi approved these changes

@WilliButz WilliButz Awaiting requested review from WilliButz

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asymmetric @Flakebi @ajs124 @hax404