Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.wasabi: 0.8.0 -> 0.8.1 #110869

Merged
merged 1 commit into from Jan 27, 2021
Merged

python3Packages.wasabi: 0.8.0 -> 0.8.1 #110869

merged 1 commit into from Jan 27, 2021

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog:
https://github.com/ines/wasabi/releases/tag/v0.8.1

Result of nixpkgs-review run on x86_64-linux 1

3 packages failed to build:
  • python37Packages.textacy
  • python38Packages.textacy
  • python39Packages.textacy
9 packages built:
  • python37Packages.spacy
  • python37Packages.thinc
  • python37Packages.wasabi
  • python38Packages.spacy
  • python38Packages.thinc
  • python38Packages.wasabi
  • python39Packages.spacy
  • python39Packages.thinc
  • python39Packages.wasabi
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110869 run on x86_64-linux 1

3 packages failed to build and are new build failures:
9 packages built:
  • python37Packages.spacy
  • python37Packages.thinc
  • python37Packages.wasabi
  • python38Packages.spacy
  • python38Packages.thinc
  • python38Packages.wasabi
  • python39Packages.spacy
  • python39Packages.thinc
  • python39Packages.wasabi

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110869 run on x86_64-linux 1

3 packages failed to build and are new build failures:
9 packages built:
  • python37Packages.spacy
  • python37Packages.thinc
  • python37Packages.wasabi
  • python38Packages.spacy
  • python38Packages.thinc
  • python38Packages.wasabi
  • python39Packages.spacy
  • python39Packages.thinc
  • python39Packages.wasabi

@danieldk
Copy link
Contributor Author

The textacy error seems to be unrelated (scikit-learn version bounds).

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110869 run on x86_64-darwin 1

3 packages failed to build and are new build failures:
  • python37Packages.textacy: log was empty
  • python38Packages.textacy: log was empty
  • python39Packages.textacy: log was empty
9 packages built:
  • python37Packages.spacy
  • python37Packages.thinc
  • python37Packages.wasabi
  • python38Packages.spacy
  • python38Packages.thinc
  • python38Packages.wasabi
  • python39Packages.spacy
  • python39Packages.thinc
  • python39Packages.wasabi

jonringer
jonringer approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/110869

3 packages failed to build:
python37Packages.textacy python38Packages.textacy python39Packages.textacy

9 packages built:
python37Packages.spacy python37Packages.thinc python37Packages.wasabi python38Packages.spacy python38Packages.thinc python38Packages.wasabi python39Packages.spacy python39Packages.thinc python39Packages.wasabi

@jonringer jonringer merged commit 15a64b2 into NixOS:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @SuperSandro2000 @jonringer