cpython: add separateDebugInfo v2 #110893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
Feb 20, 2021
risicle
force-pushed
the
ris-cpython-debug-v2
branch
from
94a8b51
to
4145595
Compare
risicle
force-pushed
the
ris-cpython-debug-v2
branch
from
4145595
to
923297b
Compare
FRidh
reviewed
Mar 20, 2021
| # debug info can't be separated from a static library and would otherwise be | ||
| # left in place by a separateDebugInfo build. force its removal here to save | ||
| # space in output. | ||
| $STRIP -S $out/lib/${libPrefix}/config-*/libpython*.a || true |
There was a problem hiding this comment.
How do we deal with debug info in case of static builds? Do we always just remove it?
Aside from this question this PR looks good to me.
There was a problem hiding this comment.
Various sources suggest that the thing to do is just put the whole debug static lib into the debug output. But doing this gets into the sticky situation of whether a debug output actually exists for platforms not supporting separateDebugInfo. And rather than doing something awkward that might break obscure platform x and get the whole PR reverted (again) I thought I'd keep this PR as straightforward as possible.
10 tasks
Closed
|
nixpkgs-review is failing to review staging PRs :( |
risicle
force-pushed
the
ris-cpython-debug-v2
branch
from
923297b
to
b9e64e8
Compare
|
Rebased on latest staging. |
debug info can't be separated from a static library and would otherwise be left in place by a separateDebugInfo build. force its removal here to save space in output.
risicle
force-pushed
the
ris-cpython-debug-v2
branch
from
b9e64e8
to
f8831c1
Compare
|
Rebased. Again. |
FRidh
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is my second attempt at #93083 which had to be reverted due to the increased size of
libpython*.a. This was because separating debug info doesn't work with static libraries and so it just gets left in place. My fairly simple solution here is to just explicitly unconditionally strip it inpostInstall.Also I note that this is only for py3, because cpython2 has been split out to a separate derivation. It's similar enough though and I could add this there too if things go well with py3.
Tested on
master(before I rebased tostaging) on non-nixos linux, nixos & macos 10.14 (all x86_64). Obviously, I have not performed a full rebuild.Seeing as this is such a core dependency, are there any of the weirder ports that should be tested? I tried to make the
$STRIP -Scommand as universal as possible but I guess it could break some more exotic systems.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)