Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

masscan: 1.3.0 -> 1.3.1 #110894

Merged
merged 2 commits into from Jan 27, 2021
Merged

masscan: 1.3.0 -> 1.3.1 #110894

merged 2 commits into from Jan 27, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 26, 2021

Motivation for this change

Update to latest upstream release 1.3.1

Change log: https://github.com/robertdavidgraham/masscan/releases/tag/1.3.1

Also, ran nixpkgs-fmt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Jan 26, 2021

Result of nixpkgs-review pr 110894 run on x86_64-linux 1

1 package built:
  • masscan

@ofborg ofborg bot requested a review from rnhmjoj January 26, 2021 21:36
@fabaff
Copy link
Member Author

fabaff commented Jan 27, 2021

Result of nixpkgs-review pr 110894 run on x86_64-linux 1

1 package built:
  • masscan

rnhmjoj
rnhmjoj approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this release is mostly bugfixes. I tested masscan with

# result/bin/masscan -p 80 0.0.0.0/0 --excludefile result/etc/masscan/exclude.conf

and seems to work all right.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110894 run on x86_64-darwin 1

1 package built:
  • masscan

@SuperSandro2000 SuperSandro2000 merged commit 78b5cfc into NixOS:master Jan 27, 2021
@fabaff fabaff deleted the bump-masscan branch January 27, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @SuperSandro2000 @rnhmjoj