Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rr: Build with gcc9 #110846

Merged
merged 1 commit into from Jan 26, 2021
Merged

rr: Build with gcc9 #110846

merged 1 commit into from Jan 26, 2021

Conversation

aij
Copy link
Contributor

@aij aij commented Jan 26, 2021

To work around linking errors with gcc10

src/AddressSpace.cc:1632: undefined reference to `rr_syscall_addr'

Fixes #110756

cc @thoughtpolice @nbp @vcunat

Motivation for this change

I want to use rr

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aij
rr: Build with gcc9
b60b402 
To work around linking errors with gcc10

    src/AddressSpace.cc:1632: undefined reference to `rr_syscall_addr'

Fixes NixOS#110756
@ofborg ofborg bot requested review from nbp and thoughtpolice January 26, 2021 12:32
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 26, 2021 •
edited

Is there an upstream patch we can fetch that fixes this?

@vcunat
Copy link
Member

vcunat commented Jan 26, 2021 •
edited

We could ask upstream, I suppose.

I had looked into this shortly and couldn't see any patch or report matching this. (I tried building their master with our expression, too) Also, Fedora uses gcc 10 and I couldn't spot any countermeasure there either. Overall I don't understand why this happens, though my knowledge about using assembler in C like this is basically zero.

@vcunat
Copy link
Member

vcunat commented Jan 26, 2021

Maybe it's actually some bug in gcc that Fedora has patched.

@Ma27 Ma27 merged commit 4bd7e25 into NixOS:master Jan 26, 2021
@collares collares mentioned this pull request Apr 24, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rr fails to build in unstable
4 participants
@aij @SuperSandro2000 @vcunat @Ma27