Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/consul: add types #110880

Merged
merged 1 commit into from Jan 29, 2021
Merged

nixos/consul: add types #110880

merged 1 commit into from Jan 29, 2021

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

#76184

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cole-h
cole-h requested changes Jan 27, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you also added services.bind types in here. Mind separating the commits? I'm fine with them both being in this PR, as long as the commits themselves are separate. (Or you can make a separate PR, up to you.)

@Scriptkiddi
Copy link
Contributor Author

Looks like you also added services.bind types in here. Mind separating the commits? I'm fine with them both being in this PR, as long as the commits themselves are separate. (Or you can make a separate PR, up to you.)

I didnt want to add bind here there is a seperate pr for that thanks for letting me know

cole-h
cole-h approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, thanks!

@cole-h cole-h merged commit 5f40e68 into NixOS:master Jan 29, 2021
@Scriptkiddi Scriptkiddi deleted the consul_types branch January 29, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Scriptkiddi @cole-h