Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tests for legacy color formats to use a box, rather than text #27337

Merged
merged 6 commits into from Feb 22, 2021
Merged

Change tests for legacy color formats to use a box, rather than text #27337

merged 6 commits into from Feb 22, 2021

Conversation

svgeesus
Copy link
Contributor

@svgeesus svgeesus commented Jan 26, 2021

Same as the changes already made to the lab(), lch() and predefined color() tests, switch from a "test passes if this text is green" to "test passes if you see a green square and no red". This makes the colored patch easier to see and with no text anti-aliasing issues. The patch is also measurable.

@svgeesus svgeesus requested review from smfr and removed request for dbaron January 26, 2021 19:41
@svgeesus svgeesus mentioned this pull request Feb 16, 2021
@svgeesus svgeesus merged commit 0377b83 into web-platform-tests:master Feb 22, 2021
@svgeesus svgeesus deleted the legacy-box-not-text branch February 23, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants