Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command plugins 2.3 #4480

Closed
wants to merge 2 commits into from
Closed

Command plugins 2.3 #4480

wants to merge 2 commits into from

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Jan 26, 2021

This makes it possible to define and use external plugins that add new nix subcommands.

Tested both with the existing in-tree plugins test and with an external command-adding plugin.

Backport of #4479

@shlevy
Move command plugin interface to libnixcmd
1e0b266 
(cherry picked from commit 6af6e41)
@shlevy
Initialize plugins before the rest of command-line parsing.
8672cad 
This makes it possible for plugins containing Nix subcommands to
actually work.

(cherry picked from commit 4917c8a)
@shlevy shlevy requested a review from edolstra January 26, 2021 14:49
@edolstra
Copy link
Member

I think we generally shouldn't add features to the stable branch, especially potentially intrusive/risky features like this one (which introduces a new library and changes command line processing).

@shlevy
Copy link
Member Author

shlevy commented Jan 27, 2021

Is there a timeline for a 2.4 release?

@edolstra edolstra modified the milestone: nix-2.4 Feb 24, 2021
@shlevy shlevy closed this Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shlevy @edolstra