Add tests for more interesting import assertion module map caching scenarios #27616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 12, 2021
…enarios Add tests for some scenarios where the module type being part of the module map cache key (along with the specifier) affects the outcome. For example, if an import of a given specifier uses the wrong module type, a later import of the same specifier should succeed if it uses the correct type assertion. Add a wpt script for testing some of the stranger cases where repeated fetches to the same specifier respond with different content types. Also add basic tests for dynamic import() with the assertions argument to the virtual/import-assertions suite. Bug: 1132413 Change-Id: I3ff4cde5a402d3d8c502fdb2bac133323c028254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2692491 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#857995}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2692491
branch
from
44407c5
to
2207ca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for some scenarios where the module type being part of the
module map cache key (along with the specifier) affects the outcome.
For example, if an import of a given specifier uses the wrong module
type, a later import of the same specifier should succeed if it uses
the correct type assertion.
Add a wpt script for testing some of the stranger cases where repeated
fetches to the same specifier respond with different content types.
Also add basic tests for dynamic import() with the assertions
argument to the virtual/import-assertions suite.
Bug: 1132413
Change-Id: I3ff4cde5a402d3d8c502fdb2bac133323c028254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2692491
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#857995}