[GridNG] Dynamic change of out of flow items #27788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 25, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2713389
branch
2 times, most recently
from
c31c1bc
to
0a4b94a
Compare
This change addresses a TODO in |UpdateGridPositionAfterStyleChange|. It triggers a full layout for GridNG when an out of flow descendant of the grid changes its style. Additionally, a web test is added to validate said behavior in an absolutely positioned child of a grid item. Bug: 1045599 Change-Id: I912bc4ba2b44cd8db53f501ff7d0119903139a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713389 Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#858226}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2713389
branch
from
0a4b94a
to
3b1eafc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a TODO in |UpdateGridPositionAfterStyleChange|. It
triggers a full layout for GridNG when an out of flow descendant of the
grid changes its style. Additionally, a web test is added to validate
said behavior in an absolutely positioned child of a grid item.
Bug: 1045599
Change-Id: I912bc4ba2b44cd8db53f501ff7d0119903139a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713389
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#858226}