Fix 02e770ff: allow estimating CloneVehicle if short on money #8748
+7
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8045
Motivation / Problem
See #8045 (comment) for the analysis.
Description
PS: this bug is 14 years old :D
Limitations
CMD_NO_TEST
functions use_additional_cash_required
, but this approach seems pretty much worse than usingCheckCompanyHasMoney
. This makes me think it would be better to change these 5 to usingCheckCompanyHasMoney
too. But, if it ain't broken, don't fix it.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.