Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 02e770ff: allow estimating CloneVehicle if short on money #8748

Merged
merged 1 commit into from Feb 26, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Feb 26, 2021

Fixes #8045

Motivation / Problem

See #8045 (comment) for the analysis.

Description

CheckCompanyHasMoney() was also executed when not using DC_EXEC,
resulting in an error about shortage of money instead of the
estimation.
This mostly is a problem for AI players, as they will have no
way to know how much it would have cost.

PS: this bug is 14 years old :D

Limitations

  • This mostly affects AI writers .. should we mention this in the changelog of AIs?
  • The other 5 CMD_NO_TEST functions use _additional_cash_required, but this approach seems pretty much worse than using CheckCompanyHasMoney. This makes me think it would be better to change these 5 to using CheckCompanyHasMoney too. But, if it ain't broken, don't fix it.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro
Copy link
Member

LordAro commented Feb 26, 2021

IMO yes, mention in AI/script changelog

CheckCompanyHasMoney() was also executed when not using DC_EXEC,
resulting in an error about shortage of money instead of the
estimation.
This mostly is a problem for AI players, as they will have no
way to know how much it would have cost.
@TrueBrain TrueBrain merged commit 9a3dbf3 into OpenTTD:master Feb 26, 2021
@TrueBrain TrueBrain deleted the fix-clonevehicle-estimate branch February 26, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI estimated costs are 0 for commands that fail while returning a cost
2 participants