Revert "Repaint when bgcolor animation is triggered" #27793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 26, 2021
This reverts commit bbf753e8c7ec7c492f4436c2bdee81278309c4d2. Reason for revert: Too much flakiness in blink_web_tests on Linux* Recent failures: - https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/98274 - https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-rel/15065 - https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/21522 Original change's description: > Repaint when bgcolor animation is triggered > > Right now when a bgcolor animation/transition is triggered, such > as hovering over an element, we do not request a repaint of the > element and thus we cannot composite the bgcolor animation. > > This CL fixes the problem by triggering a full repaint. > > Bug: 1177320 > Change-Id: I87dff5c11d109fc97f41c9b49e13b81613004281 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698847 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#857877} Bug: 1177320 Change-Id: Ifabf8f703af522a6ea25aeac3e76926478a01610 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2719692 Reviewed-by: Jiewei Qian <qjw@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#857947}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2719692
branch
from
5ce27a4
to
ce24508
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bbf753e8c7ec7c492f4436c2bdee81278309c4d2.
Reason for revert: Too much flakiness in blink_web_tests on Linux*
Recent failures:
Original change's description:
Bug: 1177320
Change-Id: Ifabf8f703af522a6ea25aeac3e76926478a01610
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2719692
Reviewed-by: Jiewei Qian <qjw@chromium.org>
Auto-Submit: Jiewei Qian <qjw@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#857947}