Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: d2803406b527
Choose a base ref
...
head repository: NixOS/nix
compare: 20ea1de77d92
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Feb 23, 2021

  1. Make DerivationGoal::drv a full Derivation

    This field used to be a `BasicDerivation`, but this `BasicDerivation`
    was downcasted to a `Derivation` when needed (implicitely or not), so we
    might as well make it a full `Derivation` and upcast it when needed.
    
    This also allows getting rid of a weird duplication in the way we
    compute the static output hashes for the derivation. We had to
    do it differently and in a different place depending on whether the
    derivation was a full derivation or just a basic drv, but we can now do
    it unconditionally on the full derivation.
    
    Fix #4559
    thufschmitt committed Feb 23, 2021
    Copy the full SHA
    ba1a256 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Copy the full SHA
    73daffb View commit details
    Browse the repository at this point in the history
  2. Use std::make_unique

    edolstra committed Feb 26, 2021
    Copy the full SHA
    20ea1de View commit details
    Browse the repository at this point in the history