abort h2 frame handling on StreamClosedError #27789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricea
approved these changes
Feb 26, 2021
stephenmcgruer
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
From the failing unittests, please fix:
./wptserve/wptserve/server.py:490:9: F841 local variable 'e' is assigned to but never used
./wptserve/wptserve/server.py:528:9: F841 local variable 'e' is assigned to but never used
./wptserve/wptserve/server.py:531:12: E111 indentation is not a multiple of four
./wptserve/wptserve/server.py:532:12: E111 indentation is not a multiple of four
In terms of the actual change itself, I will rely on @ricea 's knowledge here as I know little of h2 or ws, so generally LGTM modulo fixing the lint failures.
workaround #2778 This does not fix the issue, but in practice, allows us to run ./wpt run websockets/
jgraham
added a commit
that referenced
this pull request
Dec 20, 2023
This looks very similar to #27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable.
jgraham
added a commit
that referenced
this pull request
Dec 21, 2023
This looks very similar to #27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 24, 2023
…h2 data, a=testonly Automatic update from web-platform-tests Catch ProtocolError when trying to send h2 data This looks very similar to web-platform-tests/wpt#27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable. -- wpt-commits: fb5913ec08d888a05d3e21ba68106bdeb101138f wpt-pr: 43753
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Dec 26, 2023
…h2 data, a=testonly Automatic update from web-platform-tests Catch ProtocolError when trying to send h2 data This looks very similar to web-platform-tests/wpt#27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable. -- wpt-commits: fb5913ec08d888a05d3e21ba68106bdeb101138f wpt-pr: 43753
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 1, 2024
…h2 data, a=testonly Automatic update from web-platform-tests Catch ProtocolError when trying to send h2 data This looks very similar to web-platform-tests/wpt#27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable. -- wpt-commits: fb5913ec08d888a05d3e21ba68106bdeb101138f wpt-pr: 43753 UltraBlame original commit: 98d1490d106a7518dfe2c810f5b2032ca7d7eac1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 1, 2024
…h2 data, a=testonly Automatic update from web-platform-tests Catch ProtocolError when trying to send h2 data This looks very similar to web-platform-tests/wpt#27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable. -- wpt-commits: fb5913ec08d888a05d3e21ba68106bdeb101138f wpt-pr: 43753 UltraBlame original commit: 98d1490d106a7518dfe2c810f5b2032ca7d7eac1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 1, 2024
…h2 data, a=testonly Automatic update from web-platform-tests Catch ProtocolError when trying to send h2 data This looks very similar to web-platform-tests/wpt#27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable. -- wpt-commits: fb5913ec08d888a05d3e21ba68106bdeb101138f wpt-pr: 43753 UltraBlame original commit: 98d1490d106a7518dfe2c810f5b2032ca7d7eac1
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 5, 2024
…h2 data, a=testonly Automatic update from web-platform-tests Catch ProtocolError when trying to send h2 data This looks very similar to web-platform-tests/wpt#27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable. -- wpt-commits: fb5913ec08d888a05d3e21ba68106bdeb101138f wpt-pr: 43753
ErichDonGubler
pushed a commit
to ErichDonGubler/firefox
that referenced
this pull request
Jan 6, 2024
…h2 data, a=testonly Automatic update from web-platform-tests Catch ProtocolError when trying to send h2 data This looks very similar to web-platform-tests/wpt#27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable. -- wpt-commits: fb5913ec08d888a05d3e21ba68106bdeb101138f wpt-pr: 43753
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 16, 2024
…h2 data, a=testonly Automatic update from web-platform-tests Catch ProtocolError when trying to send h2 data This looks very similar to web-platform-tests/wpt#27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable. -- wpt-commits: fb5913ec08d888a05d3e21ba68106bdeb101138f wpt-pr: 43753 UltraBlame original commit: 4d0434914c9e18bb7c561fa93cc368fd2370df3d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 16, 2024
…h2 data, a=testonly Automatic update from web-platform-tests Catch ProtocolError when trying to send h2 data This looks very similar to web-platform-tests/wpt#27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable. -- wpt-commits: fb5913ec08d888a05d3e21ba68106bdeb101138f wpt-pr: 43753 UltraBlame original commit: 4d0434914c9e18bb7c561fa93cc368fd2370df3d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 16, 2024
…h2 data, a=testonly Automatic update from web-platform-tests Catch ProtocolError when trying to send h2 data This looks very similar to web-platform-tests/wpt#27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable. -- wpt-commits: fb5913ec08d888a05d3e21ba68106bdeb101138f wpt-pr: 43753 UltraBlame original commit: 4d0434914c9e18bb7c561fa93cc368fd2370df3d
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 23, 2024
This looks very similar to #27789 except we seem to be getting a ProtocolError rather than a StreamClosedError. Handling that by stopping trying to send more data seems pretty reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workaround #27786
This does not fix the issue, but in practice, allows us to run ./wpt run
websockets/