Something we could do instead (or additionally), to prevent that from happening again is to modify NoOpLogger methods signatures to accept multiple arguments (ie def info(self, *msg))

@Hexcles @ricea @jgraham @stephenmcgruer

Something we could do instead (or additionally), to prevent that from happening again is to modify NoOpLogger methods signatures to accept multiple arguments (ie def info(self, *msg))

I think that yes, NoOpLogger should have the same signature as the logger we are trying to use (which I believe is just https://docs.python.org/3/library/logging.html ?). So based on e.g. https://docs.python.org/3/library/logging.html#logging.Logger.info, it should be def info(msg, *args, **kwargs), but I'd be interested if @jgraham agrees or knows something otherwise :D

The logger can be a mozlog logger which doesn't support he string interpolation feature so unless we change mozlog, the current signature is correct.

The logger can be a mozlog logger which doesn't support he string interpolation feature so unless we change mozlog, the current signature is correct.

Ah, that is great to know! So our current log statements should never use the _log.info("string %s", argument) form, then? In which case this PR is 100% correct :)