Deflake WPT test registration-schedule-job.https.html #27796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so register jobs are not coalesced if they have
different updateViaCache properties, as per spec:
https://w3c.github.io/ServiceWorker/#dfn-job-equivalent
This makes the test about updateViaCache pass. The test was also
previously flaky in Chromium because it failed in two different ways
after coalescing the jobs: either registration.installing is null or
it's non-null and has the wrong updateViaCache property.
Other browsers also seemed to fail the test because they do not
make a new job and were possibly flaky. This CL also rearranges the
test to help browsers fail in a more stable way by accounting for
registration.installing being null. However it can still be flaky if
one register job is able to finish before the other one is queued up,
so it doesn't have a chance to coalesced.
Bug: 979593
Change-Id: I5395019d5733a6365b0b0ae2ae6051a077fb8176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2721300
Reviewed-by: Asami Doi <asamidoi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858476}