New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiplayer crash #8649
Comments
Are you able to download a save game from Reddit OpenTTD server 1 before it resets? If so, can you post that downloaded save game here to see if it will crash? |
How would I do that? I have now attached the result of saving the game after re-joining. I also made a backup of the entire save folder before. I did not perform an "Emergency Save". Is there anything else I should do? |
At the very least, always perform an emergency save if possible after each crash and attach the resulting savegame. |
I will do that in the future. I was not aware that that was a recommended step for reporting crashes. Since I was only spectating, I did not care if the game state was preserved locally. |
I've had the above savegame running for more than 13 game years now with no crash in sight. (Note, that's running it in singleplayer, joined to the first company. I don't know if it will be different in multiplayer as a spectator.) |
I have attached the most recent autosave from before the crash. The save is from Feb 1st, the crash occurred on the 7th as per screenshot. I could not reproduce the crash when loading the saved game (in single player). |
According to a crash analysis by DebugDiag with with the PDB of 1.10.3, the crash happens here: Because of:
If my experience with other languages is an indicator, it could be a line earlier as well, because the IP is not super reliable in a crash situation. I'm not good at after the fact diagnosing this in the OpenTTD code base, but perhaps it saves the devs some time :) |
Full call stack
|
The part of the code that caused this crash has been refactored since this bug was created. It doesn't do a pointer-resolving anymore, so for sure this specific bug is resolved. What caused the bug however, that is unclear to me. Even in 1.10.2 there shouldn't be a reason for this to happen. But as reproducing (and as such, validating the problem is resolved) is nearly impossible now, I am going to close this ticket. If, at any point in time, you experience the same issue again, please do reopen with the crashlog and savegame. Tnx! |
Version of OpenTTD
1.10.3
Steps to reproduce
Unsure if these steps will reproduce the issue. Can try again if requested. I have attached the 3 crash files to the issue.
OpenTTD crash.zip
The text was updated successfully, but these errors were encountered: