Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 81d335b081: Use non-pulsating red highlight for coverage #8622

Merged
merged 1 commit into from Feb 7, 2021
Merged

Fix 81d335b081: Use non-pulsating red highlight for coverage #8622

merged 1 commit into from Feb 7, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Jan 31, 2021

Motivation / Problem

Coverage highlights look ugly with pulsating red.

Description

I just replaced PALETTE_TILE_RED_PULSATING with PALETTE_SEL_TILE_RED for red highlights

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain added the preview This PR is receiving preview builds label Jan 31, 2021
@DorpsGek DorpsGek temporarily deployed to preview-pr-8622 January 31, 2021 09:02 Inactive
@LC-Zorg
Copy link

LC-Zorg commented Jan 31, 2021

A good change :)
Question (not request) by the way: Are there any other options available to mark also urban roads? And differently mark buildings within the station's range?
The same color of marking the station during its reconstruction also remains a problem.
I wrote this and more comments about the markings in the topic on the tt-forum.

@glx22 glx22 merged commit b927da7 into OpenTTD:master Feb 7, 2021
@glx22 glx22 deleted the highlight branch February 7, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
preview This PR is receiving preview builds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@glx22 @LC-Zorg @LordAro @TrueBrain @DorpsGek