Improve copy/paste UX in Options and Packages #275
Merged
+67
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboMaCk
changed the title
|
Thanks, much better! If the "title" is selectable, I don't think we need the meta field any more. A great bonus, if you could, would be adding a copy button :) |
|
I hijack this PR and also removed the description from the listing and showing it inside the details view as it was reported as part of the #272. |
This was
linked to
issues
Jan 25, 2021
- Change title from button to a to make it selectable - Resurect `Name` meta for Options - Make sure this won't break keyboard selection
garbas
force-pushed
the
turboMaCk/make-titles-selectable
branch
from
0eefabb to
bf21292
Compare
garbas
approved these changes
Jan 25, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the copy/paste experience especially for Options.
Namemeta for OptionsItem titles are now selectable (both packages and options):
This was broken due to support for keyboard navigation (wrapping to button) #260. Fixed in a way it's still focusable by keyboard as well as selectable*
Resurrection o
Namemeta for OptionsResolves #271 #272 #276