Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] wavpack: 5.3.0 -> 5.4.0 #110754

Merged
merged 1 commit into from Jan 27, 2021
Merged

[20.09] wavpack: 5.3.0 -> 5.4.0 #110754

merged 1 commit into from Jan 27, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

fixes #109228

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda mentioned this pull request Jan 25, 2021
Merged
3 tasks
@dotlambda dotlambda added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. labels Jan 25, 2021
@ofborg ofborg bot requested a review from codyopel January 25, 2021 11:33
@dotlambda dotlambda linked an issue Jan 25, 2021 that may be closed by this pull request
Vulnerability roundup 98: wavpack-5.3.0: 1 advisory [6.1] #109228
Closed
1 task
thiagokokada
thiagokokada approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM.

But this package is still not on master. I think it is only available in staging for now.

@dotlambda
Copy link
Member Author

But this package is still not on master. I think it is only available in staging for now.

True, which is weird given the relatively low number of rebuilds. I will rebase on staging-20.09.

@dotlambda dotlambda changed the base branch from release-20.09 to staging-20.09 January 25, 2021 14:37
@dotlambda dotlambda merged commit 4924dfe into NixOS:staging-20.09 Jan 27, 2021
@dotlambda dotlambda deleted the wavpack-5.4.0 branch January 27, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 98: wavpack-5.3.0: 1 advisory [6.1]
3 participants
@dotlambda @thiagokokada @TredwellGit