Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbiflow_write_xml_rr_graph toolchain wrapper is not installed #1973

Closed
Xiretza opened this issue Jan 25, 2021 · 4 comments
Closed

symbiflow_write_xml_rr_graph toolchain wrapper is not installed #1973

Xiretza opened this issue Jan 25, 2021 · 4 comments
Assignees

Comments

@Xiretza
Copy link
Contributor

Xiretza commented Jan 25, 2021

Needs to be added here: https://github.com/SymbiFlow/symbiflow-arch-defs/blob/bff52005b478381125b235c66f394f0f993db287/xc/common/cmake/install.cmake#L26-L34

@litghost
Copy link
Contributor

While I don't disagree that the wrapper is not installed, I'm unclear why you want it? It's typically just usefully for developers debugging the RR graph?

@litghost litghost assigned Xiretza and unassigned litghost Jan 25, 2021
@Xiretza
Copy link
Contributor Author

Xiretza commented Jan 25, 2021

I just noticed this when trying to apply my in-tree patches (including to write_xml_rr_graph) to the prebuilt tarball (which doesn't have it). Since it was the only wrapper that was missing, I assumed it was an oversight - if that's not the case, this can be closed.

@litghost
Copy link
Contributor

I don't believe it is an oversight. This wrapper is only really useful for arch-def developers. I don't believe an end user would need it. Closing for now. @acomodi Any other thoughts?

@acomodi
Copy link
Contributor

acomodi commented Jan 25, 2021

Any other thoughts?

@litghost No, I agree that this should not be required/useful for the end-user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants