Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/chromium: Simplify the logic #110715

Merged
merged 1 commit into from Jan 24, 2021
Merged

nixos/tests/chromium: Simplify the logic #110715

merged 1 commit into from Jan 24, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 24, 2021

  • Improve the documentation (Python docstrings for functions and more
    meaningful xdotool script names).
  • Make more use of the existing methods (e.g. wait_until_succeeds(), and
    send_key())
    • Note: This increases timeouts from 60 seconds to (currently)
      15 minutes but the defaults from test-driver.py should be fine.

This should make it simpler to read the code, understand the test
output, and drop the custom xdotool scripts in the future.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
nixos/tests/chromium: Simplify the logic
3dc7232 
- Improve the documentation (Python docstrings for functions and more
  meaningful xdotool script names).
- Make more use of the existing methods (e.g. wait_until_succeeds(), and
  send_key())
  - Note: This increases timeouts from 60 seconds to (currently)
    15 minutes but the defaults from test-driver.py should be fine.

This should make it simpler to read the code, understand the test
output, and drop the custom xdotool scripts in the future.
@primeos
Copy link
Member Author

primeos commented Jan 24, 2021

@GrahamcOfBorg test chromium

@primeos primeos merged commit 27955d3 into NixOS:master Jan 24, 2021
primeos added a commit to primeos/nixpkgs that referenced this pull request Feb 4, 2021
@primeos
nixos/tests/chromium: Simplify the logic (NixOS#110715)
40b3699 
- Improve the documentation (Python docstrings for functions and more
  meaningful xdotool script names).
- Make more use of the existing methods (e.g. wait_until_succeeds(), and
  send_key())
  - Note: This increases timeouts from 60 seconds to (currently)
    15 minutes but the defaults from test-driver.py should be fine.

This should make it simpler to read the code, understand the test
output, and drop the custom xdotool scripts in the future.

(cherry picked from commit 27955d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos