Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] openjpeg_1: drop #110759

Merged
merged 3 commits into from Jan 26, 2021
Merged

[20.09] openjpeg_1: drop #110759

merged 3 commits into from Jan 26, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 25, 2021 •
edited

Motivation for this change

backport of #110706
Should we actually remove openjpeg_1? It is being removed since it has open vulnerabilities.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
krita: use openjpeg_2
5253fb0 
(cherry picked from commit 27c6e5d)
@dotlambda
calligra: use openjpeg_2
9f816db 
(cherry picked from commit 0948e93)
@dotlambda dotlambda added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. labels Jan 25, 2021
@dotlambda dotlambda mentioned this pull request Jan 25, 2021
Merged
10 tasks
@talyz
Copy link
Contributor

talyz commented Jan 25, 2021

Should we actually remove openjpeg_1?

I think we should. It shouldn't be used anymore and keeping it around opens up for accidental use.

@dotlambda
openjpeg_1: drop
817f3bf 
(cherry picked from commit d846bfa)
@dotlambda dotlambda changed the title [20.09] calligra, krita: use openjpeg_2 [20.09] openjpeg_1: drop Jan 25, 2021
@talyz
Copy link
Contributor

talyz commented Jan 26, 2021

Result of nixpkgs-review pr 110759 run on x86_64-linux 1

3 packages built:
  • calligra
  • gmic-qt-krita
  • krita

@dotlambda dotlambda merged commit ee33fe9 into NixOS:release-20.09 Jan 26, 2021
@dotlambda dotlambda deleted the openjpeg_1-drop branch January 26, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz talyz approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: clean-up 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @talyz