Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uchardet: disable check on i686 #110737

Closed
wants to merge 1 commit into from
Closed

uchardet: disable check on i686 #110737

wants to merge 1 commit into from

Conversation

siraben
Copy link
Member

@siraben siraben commented Jan 25, 2021

Motivation for this change

The check fails on i686

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cstrahan January 25, 2021 05:03
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 25, 2021 •
edited

The check fails on i686

Do you have a log or reported this upstream? We might want to add a comment with some more information.

@siraben
Copy link
Member Author

siraben commented Jan 25, 2021

This was reported by another user running i686 on #nixos.

log: https://logs.nix.samueldr.com/nixos/2021-01-23#4521395;

The following tests FAILED:
         29 - fi:iso-8859-1 (Failed)
         37 - ga:iso-8859-1 (Failed)
        106 - th:tis-620 (Failed)
Errors while running CTest
make: *** [Makefile:127: test] Error 8
builder for '/nix/store/7k0970580kzadwpybrrypjdxswh63y5c-uchardet-0.0.7.drv' failed with exit code 2
cannot build derivation '/nix/store/6n22sn3x8sdl6fklyvv91nxpfg27dcm4-mpv-0.32.0.drv': 1 dependencies couldn't be built
building '/nix/store/6i7sagwmqp228r2801j2a2if2mxwwcdf-xsession.drv'...
building '/nix/store/z25l2kpn3g102f5qadafqcmkmxs1sci6-xsession.drv'...
cannot build derivation '/nix/store/14gydj27lfixny1qga3ysrvbqqw7yvir-mpv-with-scripts-0.32.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/63nzcv9zs8zw72hn029h5bh7sq7m1dls-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gk6qirajwnjnrs0gir8q0hnsk3zqb67f-nixos-system-Studio-1555-NixOS-20.09.2660.da3378c4aaf.drv': 1 dependencies couldn't be built
error: build of '/nix/store/gk6qirajwnjnrs0gir8q0hnsk3zqb67f-nixos-system-Studio-1555-NixOS-20.09.2660.da3378c4aaf.drv' failed

SuperSandro2000
SuperSandro2000 reviewed Jan 25, 2021
View reviewed changes
pkgs/development/libraries/libuchardet/default.nix
@@ -17,7 +17,7 @@ stdenv.mkDerivation rec {
"-DCMAKE_SKIP_BUILD_RPATH=OFF" # for tests
];

doCheck = true;
doCheck = !stdenv.isi686;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
doCheck = !stdenv.isi686;
# The following tests FAILED:
# 29 - fi:iso-8859-1 (Failed)
# 37 - ga:iso-8859-1 (Failed)
# 106 - th:tis-620 (Failed)
# Errors while running CTest
# make: *** [Makefile:127: test] Error 8
doCheck = !stdenv.isi686;

A bit long but at least we know what failed. Does an upstream issue exist for this? Maybe we should link it or create one if it does not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug is probably https://bugs.freedesktop.org/show_bug.cgi?id=101033. Tl;DR is that uchardet's test relies on sort order of floating point values. And the values are slightly different on i387 (pre-sse2) due to excessive precision.

@stale
Copy link

stale bot commented Jul 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 26, 2021
@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Sep 23, 2021
vcunat
vcunat requested changes Sep 24, 2021
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know... pkgsi686Linux.libuchardet is fine for me on current nixpkgs master. I retried a couple times on two different machines. (same version as in your commit)

@vcunat
Copy link
Member

vcunat commented Sep 24, 2021

🤦🏽 this PR is a duplicate of #112300

@vcunat vcunat closed this Sep 24, 2021
@siraben siraben deleted the libuchardet-i686 branch September 25, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trofi trofi trofi left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@vcunat vcunat vcunat requested changes

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
2.status: duplicate 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siraben @SuperSandro2000 @vcunat @trofi