Skip to content

nixos/binfmt: add bash to sandboxPaths #110739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

nixos/binfmt: add bash to sandboxPaths #110739

merged 1 commit into from
Jan 25, 2021
+2 −2

Conversation

matthewbauer
Copy link
Member

bash is needed to run the new binfmt shell script.

Fixes #110540

@matthewbauer
nixos/binfmt: add bash to sandboxPaths
35bd8f1 
bash is needed to run the new binfmt shell script.

Fixes NixOS#110540
@matthewbauer matthewbauer mentioned this pull request Jan 25, 2021
Closed
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 25, 2021
mohe2015
mohe2015 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@mohe2015 mohe2015 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. It works for me and looks like a really nice way to fix this. Also interesting to learn more about the sandbox.

@matthewbauer matthewbauer merged commit e8338c9 into NixOS:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohe2015 mohe2015

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't compile aarch64 images on x86_64 with qemu aarch64 binfmt and flake master
2 participants
@matthewbauer @mohe2015