Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "webkitgtk: enable WPE_RENDERER" #110738

Merged
merged 1 commit into from Jan 25, 2021
Merged

Revert "webkitgtk: enable WPE_RENDERER" #110738

merged 1 commit into from Jan 25, 2021

Conversation

matthewbauer
Copy link
Member

This reverts commit 132f7e6.

This commit broke evolution & epiphany webkitgtk in some cases. See #110468. Unclear exactly what broke, but best to revert to be safe.

@matthewbauer matthewbauer mentioned this pull request Jan 25, 2021
Closed
@SuperSandro2000
Copy link
Member

@ofborg build evolution

worldofpeace
worldofpeace approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test that the programs work again, but if they did before this commit it's highly likely.
Thanks for the revert, I would hope to be able to re-enable this again at some point.

@dasj19
Copy link
Contributor

dasj19 commented Jan 25, 2021

I am running: nix-shell -p nixpkgs-review --run "nixpkgs-review pr 110738"

So far I encountered the following issues:

waiting for locks or build slots...
builder for '/nix/store/qkdnn6rsbiwiry5ibah2cdvdkqdpcgwm-linuxx64-20.12.0.12.tar.gz.drv' failed with exit code 1; last 10 log lines:
  (if you do not find version 20.12.0.12 there, try at
  https://www.citrix.com/downloads/workspace-app/
  
  Once you have downloaded the file, please use the following command and re-run the
  installation:
  
  nix-prefetch-url file://$PWD/linuxx64-20.12.0.12.tar.gz
  
  ***
builder for '/nix/store/ipjzirsin7dfr93j53cqyzypwh7y0jqd-linuxx64-20.04.0.21.tar.gz.drv' failed with exit code 1; last 10 log lines:
  (if you do not find version 20.04.0.21 there, try at
  https://www.citrix.com/downloads/workspace-app/
  
  Once you have downloaded the file, please use the following command and re-run the
  installation:
  
  nix-prefetch-url file://$PWD/linuxx64-20.04.0.21.tar.gz
  
  ***
builder for '/nix/store/3l4pkk3lnlzhvksksdk65qr615n92a83-linuxx64-20.06.0.15.tar.gz.drv' failed with exit code 1; last 10 log lines:
  (if you do not find version 20.06.0.15 there, try at
  https://www.citrix.com/downloads/workspace-app/
  
  Once you have downloaded the file, please use the following command and re-run the
  installation:
  
  nix-prefetch-url file://$PWD/linuxx64-20.06.0.15.tar.gz
  
  ***
builder for '/nix/store/a5yv4bx8d8an52ikkpgwn6ah76qairj4-linuxx64-20.10.0.6.tar.gz.drv' failed with exit code 1; last 10 log lines:
  (if you do not find version 20.10.0.6 there, try at
  https://www.citrix.com/downloads/workspace-app/
  
  Once you have downloaded the file, please use the following command and re-run the
  installation:
  
  nix-prefetch-url file://$PWD/linuxx64-20.10.0.6.tar.gz
  
  ***
builder for '/nix/store/fh7yaczn9kknk3hqskb9f74a2ljs7pwj-linuxx64-20.9.0.15.tar.gz.drv' failed with exit code 1; last 10 log lines:
  (if you do not find version 20.9.0.15 there, try at
  https://www.citrix.com/downloads/workspace-app/
  
  Once you have downloaded the file, please use the following command and re-run the
  installation:
  
  nix-prefetch-url file://$PWD/linuxx64-20.9.0.15.tar.gz
  
  ***

Still waiting for the command to finnish... but apparently it breaks linuxx64

@worldofpeace
Copy link
Contributor

I don't think that's possible. That message appears to be part of evaluation citrix-workspace, which is maybe being rebuild because of webkitgtk changing. Actually, rebuilding webkitgtk is a huge chore... Involving several hours so I don't recommend using nix review on this PR

@SuperSandro2000 SuperSandro2000 merged commit 0409523 into NixOS:master Jan 25, 2021
@jtojnar jtojnar mentioned this pull request May 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@dasj19 dasj19 Awaiting requested review from dasj19

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @SuperSandro2000 @dasj19 @worldofpeace