Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytestCheckHook: Fix support for spaces in disabled file paths #110700

Merged
merged 2 commits into from Jan 24, 2021
Merged

pytestCheckHook: Fix support for spaces in disabled file paths #110700

merged 2 commits into from Jan 24, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

Fixes an oversight in #108529 found by @dotlambda.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt requested a review from FRidh as a code owner January 24, 2021 15:29
@mweinelt mweinelt force-pushed the pytestcheckhook-disabledfiles-spacing branch from cc1bd45 to 8402b93 Compare January 24, 2021 15:30
@mweinelt
pytestCheckHook: Fix support for multiple files.
83fc563 
Quoting here will lead to the shell treating them as a single item.
@mweinelt
Copy link
Member Author

@dotlambda Can you give this a shot?

dotlambda
dotlambda approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included your commits in #110474.

jonringer
jonringer approved these changes Jan 24, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

should we just merge this and then have the other PR get rebased?

@mweinelt
Copy link
Member Author

Yep, let's do it.

@jonringer jonringer merged commit 0f5743b into NixOS:staging Jan 24, 2021
@mweinelt mweinelt deleted the pytestcheckhook-disabledfiles-spacing branch January 24, 2021 23:48
@mweinelt mweinelt mentioned this pull request Feb 15, 2021
Merged
10 tasks
@SuperSandro2000 SuperSandro2000 mentioned this pull request Feb 15, 2021
Closed
@rmcgibbo rmcgibbo mentioned this pull request Feb 15, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @dotlambda @jonringer