Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad-driver-podman: init at 0.2.0 #110701

Merged
merged 2 commits into from Jan 24, 2021
Merged

nomad-driver-podman: init at 0.2.0 #110701

merged 2 commits into from Jan 24, 2021

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jan 24, 2021

Motivation for this change

Initialize the Nomad Podman driver at version 0.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit January 24, 2021 15:43
@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 110701 run on x86_64-linux 1

1 package built:
  • nomad-driver-podman

@lovesegfault lovesegfault merged commit 5bc0a68 into NixOS:master Jan 24, 2021
@cpcloud cpcloud deleted the nomad-driver-podman branch January 24, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpcloud @lovesegfault