Remove the defunct "burger menu" and always expand the navigation #273
+2
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I commonly run into a situation where the burger menu button is being showed to me but it broke some time ago and doesn't expand the menu anymore. Since the snipped was probably mostly 1:1 translated from the old nixos.org page (where we had more links than just the three we have now) we can probably just remove it now. It is a net win as the feature was broken and at least now you can use the website on mobile again.
|
@andir The burger menu is visible for now this was fixed by @turboMaCk in #267. This PR just removes the working burger menu. To be honest I have no opinion on this because this is going to be changed in the coming PRs:
Since I'm without opinion I'm merging this since I really appreciate you taking the time to actually submit a PR. Thank you, thank you, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I commonly run into a situation where the burger menu button is being
showed to me but it broke some time ago and doesn't expand the menu
anymore.
Since the snipped was probably mostly 1:1 translated from the old
nixos.org page (where we had more links than just the three we have now)
we can probably just remove it now. It is a net win as the feature was
broken and at least now you can use the website on mobile again.