Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't createHome for the hydra user #110722

Merged
merged 2 commits into from Jan 29, 2021
Merged

Don't createHome for the hydra user #110722

merged 2 commits into from Jan 29, 2021

Conversation

Gabriella439
Copy link
Contributor

… since hydra-init already takes care of creating /var/lib/hydra,
which is hydra's home directory

Motivation for this change

Fixes #109481

Things done

I tested that this works for the hydra service run by dhall-lang.org: dhall-lang/dhall-lang#1133

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gabriella439
Don't createHome for the hydra user
9a79d75 
… since `hydra-init` already takes care of creating `/var/lib/hydra`,
which is `hydra`'s home directory

Fixes NixOS#109481
@Gabriella439 Gabriella439 mentioned this pull request Jan 24, 2021
Closed
@aanderse
Copy link
Member

aanderse commented Jan 24, 2021 •
edited

@GrahamcOfBorg test hydra

edit: maybe I need to run that locally...

@Gabriella439 @cole-h
Document why we don't enable createHome
6f298e1 
Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com>
cole-h
cole-h approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Please squash the commits :)

Nit: if you feel like it, it would also be cool to reflow the comment, because it's a little long for one line IMO.

@cole-h
Copy link
Member

cole-h commented Jan 26, 2021

@ofborg test hydra

@cole-h cole-h mentioned this pull request Jan 29, 2021
Closed
10 tasks
@Mic92 Mic92 merged commit 80f6769 into NixOS:master Jan 29, 2021
aforemny pushed a commit to aforemny/nixpkgs that referenced this pull request Mar 4, 2021
@Gabriella439 @cole-h @aforemny
Don't createHome for the hydra user (NixOS#110722)
bb7d2f4 
Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com>
@aanderse aanderse mentioned this pull request Mar 7, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse left review comments

@cole-h cole-h cole-h approved these changes

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running activation script causes Hydra to fail with permissions error
4 participants
@Gabriella439 @aanderse @cole-h @Mic92