Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lowdown: fix dylib on darwin #110740

Merged
merged 1 commit into from Jan 25, 2021
Merged

lowdown: fix dylib on darwin #110740

merged 1 commit into from Jan 25, 2021

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Jan 25, 2021

Lowdown's dynamic library isn't set up properly on darwin, leading to downstream errors such as:

dyld: Library not loaded: liblowdown.so
  Referenced from: /nix/store/d3kin0fzkxkpd9i1fk9j338hb51zcf5q-nix-2.4pre20201205_a5d85d0/bin/nix
  Reason: image not found

(https://hydra.nixos.org/build/135748474/nixlog/1)

Previously we only built lowdown statically, so this wasn't an issue until #97070 (cc @Ericson2314)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 25, 2021
@ofborg ofborg bot requested a review from sternenseemann January 25, 2021 05:59
@r-burns r-burns mentioned this pull request Jan 25, 2021
Closed
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 25, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110740 run on x86_64-darwin 1

6 packages built:
  • disnix
  • dydisnix
  • lowdown
  • nix-update
  • nixFlakes (nixUnstable)
  • nixpkgs-review

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110740 run on x86_64-linux 1

8 packages built:
  • disnix
  • disnixos
  • dydisnix
  • hydra-unstable
  • lowdown
  • nix-update
  • nixFlakes (nixUnstable)
  • nixpkgs-review

@r-burns
Copy link
Contributor Author

r-burns commented Jan 25, 2021

Hmm, the first time I tried this nixUnstable was still failing, but I tried to build again and it passed. I'm not sure if a test is flaky, or if it depends on sandbox behavior, or something else.

@SuperSandro2000
Copy link
Member

Hmm, the first time I tried this nixUnstable was still failing, but I tried to build again and it passed. I'm not sure if a test is flaky, or if it depends on sandbox behavior, or something else.

I've run it again and now it succeeds. Not sure why.

@SuperSandro2000 SuperSandro2000 merged commit ce7b327 into NixOS:master Jan 25, 2021
@r-burns r-burns deleted the lowdown branch January 25, 2021 10:30
@Ericson2314
Copy link
Member

Thanks!

@sternenseemann
Copy link
Member

Thank you for fixing this up, I wondered about darwin yesterday, but forgot to test.

Can confirm nixUnstable built fine for me on darwin with this and :doc in nix repl works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-burns @SuperSandro2000 @Ericson2314 @sternenseemann