Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjpeg_1: drop #110706

Merged
merged 5 commits into from Jan 25, 2021
Merged

openjpeg_1: drop #110706

merged 5 commits into from Jan 25, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

open vulnerabilities: #109201

Should we backport this to 20.09 in order to completely fix #109201?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@ofborg build krita calligra

@worldofpeace
Copy link
Contributor

Should we backport this to 20.09 in order to completely fix #109201?

Sure. No one should be using it anyways

cole-h
cole-h reviewed Jan 25, 2021
View reviewed changes
pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 110706 run on x86_64-linux 1

3 packages built:
  • calligra
  • gmic-qt-krita
  • krita

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 25, 2021
@dotlambda
openjpeg: clean-up
8c9a72e 
Merge generic.nix and 2.x.nix into default.nix.
openjpeg_2 is now an alias
dotlambda
dotlambda commented Jan 25, 2021
View reviewed changes
pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@dotlambda
openjpeg_2_1: remove alias
e0dd8c6 
It is actually referring to version 2.4.
@talyz
Copy link
Contributor

talyz commented Jan 25, 2021

Result of nixpkgs-review pr 110706 run on x86_64-linux 1

3 packages built:
  • calligra
  • gmic-qt-krita
  • krita

@SuperSandro2000 SuperSandro2000 merged commit 7a59fcd into NixOS:master Jan 25, 2021
@dotlambda dotlambda deleted the openjpeg_1-drop branch January 25, 2021 11:59
@dotlambda dotlambda mentioned this pull request Jan 25, 2021
Merged
10 tasks
@dotlambda
Copy link
Member Author

The backport is in #110759.

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@cole-h cole-h cole-h left review comments

@talyz talyz talyz approved these changes

@lovesegfault lovesegfault lovesegfault approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@mkg20001 mkg20001 Awaiting requested review from mkg20001

@TredwellGit TredwellGit Awaiting requested review from TredwellGit

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
8.has: clean-up 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 98: openjpeg-1.5.2: 5 advisories [7.8]
7 participants
@dotlambda @SuperSandro2000 @worldofpeace @lovesegfault @talyz @cole-h @erictapen